Issue 149341: DevTools: show property type names in Elements panel and Console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149341: DevTools: show property type names in Elements panel and Console (Closed)

Created:
11 years, 5 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: show property type names in Elements panel and Console. BUG=15988 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20253

Patch Set 4 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -28 lines)			Patch
	M	webkit/glue/devtools/js/devtools.js	View		4 chunks	+19 lines, -21 lines	0 comments	Download
	M	webkit/glue/devtools/js/inject.js	View	1 2 3	3 chunks	+30 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM with comments http://codereview.chromium.org/149341/diff/1/2 File webkit/glue/devtools/js/inject.js (right): http://codereview.chromium.org/149341/diff/1/2#newcode110 Line 110: result.push(undefined); what is this forth ...

11 years, 5 months ago (2009-07-08 20:22:19 UTC) #2

yurys

11 years, 5 months ago (2009-07-09 07:23:09 UTC) #3

I've also added function signature formatting for methods.

http://codereview.chromium.org/149341/diff/1/2
File webkit/glue/devtools/js/inject.js (right):

http://codereview.chromium.org/149341/diff/1/2#newcode110
Line 110: result.push(undefined);
On 2009/07/08 20:22:19, pfeldman wrote:
> what is this forth parameter? jsdoc it?

Done.

http://codereview.chromium.org/149341/diff/1/2#newcode144
Line 144: return (value == null) ? 'null' : value.constructor.name;
On 2009/07/08 20:22:19, pfeldman wrote:
> can constructor be null?
No.

Expand Messages | Collapse Messages

Issue 149341: DevTools: show property type names in Elements panel and Console (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages