Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: src/debug/arm64/debug-arm64.cc

Issue 1493363002: [debugger] do not restart frames that reference new.target for liveedit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/arm/debug-arm.cc ('k') | src/debug/ia32/debug-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/arm64/frames-arm64.h" 7 #include "src/arm64/frames-arm64.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 10
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 141
142 // We do not know our frame height, but set sp based on fp. 142 // We do not know our frame height, but set sp based on fp.
143 __ Sub(masm->StackPointer(), fp, kPointerSize); 143 __ Sub(masm->StackPointer(), fp, kPointerSize);
144 __ AssertStackConsistency(); 144 __ AssertStackConsistency();
145 145
146 __ Pop(x1, fp, lr); // Function, Frame, Return address. 146 __ Pop(x1, fp, lr); // Function, Frame, Return address.
147 147
148 // Load context from the function. 148 // Load context from the function.
149 __ Ldr(cp, FieldMemOperand(x1, JSFunction::kContextOffset)); 149 __ Ldr(cp, FieldMemOperand(x1, JSFunction::kContextOffset));
150 150
151 // Clear new.target as a safety measure.
152 __ LoadRoot(x3, Heap::kUndefinedValueRootIndex);
153
151 // Get function code. 154 // Get function code.
152 __ Ldr(scratch, FieldMemOperand(x1, JSFunction::kSharedFunctionInfoOffset)); 155 __ Ldr(scratch, FieldMemOperand(x1, JSFunction::kSharedFunctionInfoOffset));
153 __ Ldr(scratch, FieldMemOperand(scratch, SharedFunctionInfo::kCodeOffset)); 156 __ Ldr(scratch, FieldMemOperand(scratch, SharedFunctionInfo::kCodeOffset));
154 __ Add(scratch, scratch, Code::kHeaderSize - kHeapObjectTag); 157 __ Add(scratch, scratch, Code::kHeaderSize - kHeapObjectTag);
155 158
156 // Re-run JSFunction, x1 is function, cp is context. 159 // Re-run JSFunction, x1 is function, cp is context.
157 __ Br(scratch); 160 __ Br(scratch);
158 } 161 }
159 162
160 163
161 const bool LiveEdit::kFrameDropperSupported = true; 164 const bool LiveEdit::kFrameDropperSupported = true;
162 165
163 } // namespace internal 166 } // namespace internal
164 } // namespace v8 167 } // namespace v8
165 168
166 #endif // V8_TARGET_ARCH_ARM64 169 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/debug/arm/debug-arm.cc ('k') | src/debug/ia32/debug-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698