Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1493363002: [debugger] do not restart frames that reference new.target for liveedit. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] do not restart frames that reference new.target for liveedit. R=mstarzinger@chromium.org Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682 Cr-Commit-Position: refs/heads/master@{#32572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -77 lines) Patch
M src/ast/scopeinfo.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M src/debug/arm/debug-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/ia32/debug-ia32.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/debug/liveedit.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 10 chunks +93 lines, -34 lines 0 comments Download
M src/debug/liveedit.js View 4 chunks +27 lines, -18 lines 0 comments Download
M src/debug/mips/debug-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/debug/x64/debug-x64.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +23 lines, -11 lines 0 comments Download
A test/mjsunit/es6/debug-liveedit-new-target-1.js View 1 chunk +75 lines, -0 lines 0 comments Download
A test/mjsunit/es6/debug-liveedit-new-target-2.js View 1 chunk +63 lines, -0 lines 0 comments Download
A test/mjsunit/es6/debug-liveedit-new-target-3.js View 1 chunk +73 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-390925.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
5 years ago (2015-12-03 14:31:40 UTC) #1
Michael Starzinger
LGTM on the integration pieces, didn't look at the "liveedit" part too closely an mostly ...
5 years ago (2015-12-03 14:37:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493363002/1
5 years ago (2015-12-03 14:50:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 15:18:54 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682 Cr-Commit-Position: refs/heads/master@{#32572}
5 years ago (2015-12-03 15:19:24 UTC) #7
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1493863004/ by machenbach@chromium.org. ...
5 years ago (2015-12-03 18:38:16 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-03 20:16:06 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698