Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1493323002: Renamed authorStyleSheets to injectedAuthorStyleSheets. (Closed)

Created:
5 years ago by rune
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed authorStyleSheets to injectedAuthorStyleSheets. The naming in StyleEngine was too general to grasp which stylesheets these actually were. They are stylesheets injected through WebDocument::insertStyleSheet which are injected by extensions afaict. R=jochen@chromium.org Committed: https://crrev.com/b4e689e5049a21c645f215e8a01c28c6fad22b7f Cr-Commit-Position: refs/heads/master@{#363219}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493323002/1
5 years ago (2015-12-03 12:25:50 UTC) #2
rune
ptal
5 years ago (2015-12-03 12:25:51 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 14:46:37 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-04 13:15:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493323002/1
5 years ago (2015-12-04 13:53:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-04 16:23:33 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-04 16:25:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4e689e5049a21c645f215e8a01c28c6fad22b7f
Cr-Commit-Position: refs/heads/master@{#363219}

Powered by Google App Engine
This is Rietveld 408576698