Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1493313003: simplify nanobench --quiet / -q output (Closed)

Created:
5 years ago by mtklein_C
Modified:
5 years ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify nanobench --quiet / -q output This tries to cut things down to the very minimum you might want to know: $ out/Release/nanobench --match nytimes --config 8888 gpu -q Timer overhead: 29.6ns ! -> high variance, ? -> moderate variance micros bench 2479.05 ! desk_nytimes.skp_1_mpd 8888 1313.92 desk_nytimes.skp_1_mpd gpu 3617.65 desk_nytimes.skp_1 8888 1158.34 desk_nytimes.skp_1 gpu 1368.99 ! keymobi_nytimes_com_.skp_1_mpd 8888 393.40 keymobi_nytimes_com_.skp_1_mpd gpu 1179.68 ! keymobi_nytimes_com_.skp_1 8888 342.74 keymobi_nytimes_com_.skp_1 gpu All times are printed in microseconds, and high variance runs are marked. BUG=skia: Committed: https://skia.googlesource.com/skia/+/66cfcffd5d0a430f00bf0e36bedb088a25957183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M bench/nanobench.cpp View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mtklein
5 years ago (2015-12-03 20:56:52 UTC) #2
reed1
commas?
5 years ago (2015-12-03 21:31:34 UTC) #3
reed1
lgtm
5 years ago (2015-12-03 21:31:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493313003/1
5 years ago (2015-12-03 22:04:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_TIMED_OUT, no build URL) Build-Ubuntu-Clang-x86_64-Debug-Trybot on ...
5 years ago (2015-12-04 00:05:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493313003/1
5 years ago (2015-12-04 14:33:06 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-04 14:35:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/66cfcffd5d0a430f00bf0e36bedb088a25957183

Powered by Google App Engine
This is Rietveld 408576698