Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 1493293002: Align gyp and GN in //components/sessions dependencies (Closed)

Created:
5 years ago by blundell
Modified:
5 years ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Align gyp and GN in //components/sessions dependencies //components/sessions depends on both //components/keyed_service/core and //components/variations. GN and GYP were missing the first and the second respectively. Committed: https://crrev.com/930d9fd95574465735ea01121d416a9c1257f0a0 Cr-Commit-Position: refs/heads/master@{#362956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/sessions.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
blundell
5 years ago (2015-12-03 10:35:36 UTC) #2
sdefresne
lgtm
5 years ago (2015-12-03 11:10:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493293002/1
5 years ago (2015-12-03 11:14:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 11:39:13 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 11:39:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930d9fd95574465735ea01121d416a9c1257f0a0
Cr-Commit-Position: refs/heads/master@{#362956}

Powered by Google App Engine
This is Rietveld 408576698