Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1493253002: CSSPreloadScanner should handle <base> adjusted URLs (Closed)

Created:
5 years ago by kouhei (in TOK)
Modified:
5 years ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSSPreloadScanner should handle <base> adjusted URLs Before this CL, CSSPreloadScanner didn't handle <base> element adjusted relative URLs. This CL adds support for it. BUG=511935 Committed: https://crrev.com/51a61fd376238532a0013796b9cc134726c6a0da Cr-Commit-Position: refs/heads/master@{#362964}

Patch Set 1 #

Patch Set 2 : add LayoutTests #

Patch Set 3 : ensure init pointers at c-tor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
A + third_party/WebKit/LayoutTests/fast/preloader/style-base.html View 1 1 chunk +5 lines, -14 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/preloader/style-base-expected.txt View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.h View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp View 1 2 3 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
kouhei (in TOK)
5 years ago (2015-12-03 05:24:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493253002/20001
5 years ago (2015-12-03 05:27:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 06:35:09 UTC) #6
Yoav Weiss
On 2015/12/03 06:35:09, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-03 06:55:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493253002/40001
5 years ago (2015-12-03 12:51:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-03 12:56:30 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 12:57:27 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/51a61fd376238532a0013796b9cc134726c6a0da
Cr-Commit-Position: refs/heads/master@{#362964}

Powered by Google App Engine
This is Rietveld 408576698