Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149323002: Ensure the Desktop App Launcher warmup window is not created while trying to quit (Closed)

Created:
6 years, 10 months ago by tapted
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, joi+watch-content_chromium.org, tfarina, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, ben+views_chromium.org
Visibility:
Public.

Description

Ensure the Desktop App Launcher warmup window is not created while trying to quit. When relaunching from Metro there is a lengthier time-window where BrowserProcess::IsShuttingDown() is false, but browser_shutdown::IsTryingToQuit() is true. If the app launcher delayed warmup (and the non-delayed asynchronous profile load it triggers) is unlucky enough to get scheduled here, then it can create a window after Widget::CloseAllSecondaryWidgets() has been called on the shutdown path, which otherwise would have mopped up the app launcher resources. Checking browser_shutdown::IsTryingToQuit ensures the app launcher window won't be created after Widget::CloseAllSecondaryWidgets() would have been called during shutdown. BUG=333350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247906

Patch Set 1 #

Patch Set 2 : Rebase, and fix #

Patch Set 3 : Just the fix #

Patch Set 4 : ugh. missing include - culled too much #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tapted
koz, could you take a look? There is some tracing I've added to http://crbug.com/333350#c7 which ...
6 years, 10 months ago (2014-01-29 05:44:40 UTC) #1
koz (OOO until 15th September)
lgtm Nice catch!
6 years, 10 months ago (2014-01-29 06:18:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/149323002/40001
6 years, 10 months ago (2014-01-29 06:22:29 UTC) #3
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-29 08:18:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/149323002/60001
6 years, 10 months ago (2014-01-29 08:20:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253391
6 years, 10 months ago (2014-01-29 09:54:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/149323002/60001
6 years, 10 months ago (2014-01-29 10:49:36 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=253419
6 years, 10 months ago (2014-01-29 13:38:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/149323002/60001
6 years, 10 months ago (2014-01-29 21:02:54 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 08:56:35 UTC) #10
Message was sent while issue was closed. 
Change committed as 247906

Powered by Google App Engine
This is Rietveld 408576698