Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1493213002: X87: [turbofan] Implemented the optional Float32RoundTruncate operator. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Implemented the optional Float32RoundTruncate operator. port 19741ac977ea0fae9a01fb78356cb84d546629b8 (r32301) original commit message: The Float32RoundTruncate operator rounds float32 numbers towards zero. The operator is currently implemented on x64, ia32, arm, and arm64. Additionally I added support for the float32 vrintz, vrintn, and vrinta instructions to the arm simulator. BUG= Committed: https://crrev.com/d03dc2a1355cc44835721fc6c07423bd93af39ad Cr-Commit-Position: refs/heads/master@{#32537}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-03 02:43:25 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-03 04:39:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493213002/1
5 years ago (2015-12-03 04:40:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 05:19:48 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 05:20:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d03dc2a1355cc44835721fc6c07423bd93af39ad
Cr-Commit-Position: refs/heads/master@{#32537}

Powered by Google App Engine
This is Rietveld 408576698