Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1493183002: Enable WebUSB on Android. (Closed)

Created:
5 years ago by Reilly Grant (use Gerrit)
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebUSB on Android. This change finishes up the work done to remove #ifdefs disabling USB on Android by making the WebUSB flag available on all platforms and removing the #ifdef preventing the WebUSBClient from being provided to the render frame on Android. BUG=492204 Committed: https://crrev.com/d55e30c0ecc69e95377d7417a60f8eff585a25c4 Cr-Commit-Position: refs/heads/master@{#363826}

Patch Set 1 #

Patch Set 2 : Fix GYP build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -39 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -9 lines 0 comments Download
M content/content_renderer.gypi View 1 4 chunks +1 line, -9 lines 0 comments Download
M content/renderer/BUILD.gn View 1 4 chunks +2 lines, -16 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years ago (2015-12-03 01:55:39 UTC) #2
pfeldman
lgtm
5 years ago (2015-12-03 18:50:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493183002/20001
5 years ago (2015-12-08 00:35:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/89591) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-12-08 01:07:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493183002/20001
5 years ago (2015-12-08 22:27:04 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-08 23:26:11 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-08 23:27:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d55e30c0ecc69e95377d7417a60f8eff585a25c4
Cr-Commit-Position: refs/heads/master@{#363826}

Powered by Google App Engine
This is Rietveld 408576698