Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 149313005: Update android WebView to use WebElementCollection instead of WebNodeCollection (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Update android WebView to use WebElementCollection instead of WebNodeCollection Update android WebView to use WebElementCollection instead of WebNodeCollection. After Blink r166411 and r166500, WebNodeCollection is renamed to WebElementCollection and its API returns WebElements instead of WebNodes. The new code is clearer and avoids an unnecessary isElementNode() check. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250284

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Update argument type #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M android_webview/renderer/aw_render_view_ext.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Inactive
6 years, 10 months ago (2014-02-07 14:14:59 UTC) #1
benm (inactive)
thanks! https://codereview.chromium.org/149313005/diff/40001/android_webview/renderer/aw_render_view_ext.cc File android_webview/renderer/aw_render_view_ext.cc (right): https://codereview.chromium.org/149313005/diff/40001/android_webview/renderer/aw_render_view_ext.cc#newcode57 android_webview/renderer/aw_render_view_ext.cc:57: blink::WebElement GetImgChild(const blink::WebNode& node) { Should the parameter ...
6 years, 10 months ago (2014-02-07 14:46:15 UTC) #2
Inactive
https://codereview.chromium.org/149313005/diff/40001/android_webview/renderer/aw_render_view_ext.cc File android_webview/renderer/aw_render_view_ext.cc (right): https://codereview.chromium.org/149313005/diff/40001/android_webview/renderer/aw_render_view_ext.cc#newcode57 android_webview/renderer/aw_render_view_ext.cc:57: blink::WebElement GetImgChild(const blink::WebNode& node) { On 2014/02/07 14:46:15, benm ...
6 years, 10 months ago (2014-02-07 15:09:41 UTC) #3
Inactive
ping review?
6 years, 10 months ago (2014-02-10 20:32:48 UTC) #4
benm (inactive)
lgtm sorry for the delay
6 years, 10 months ago (2014-02-10 21:14:05 UTC) #5
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-10 21:24:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/149313005/100001
6 years, 10 months ago (2014-02-10 21:25:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 22:02:15 UTC) #8
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=148324
6 years, 10 months ago (2014-02-10 22:02:16 UTC) #9
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-10 22:27:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/149313005/410001
6 years, 10 months ago (2014-02-10 22:32:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/149313005/410001
6 years, 10 months ago (2014-02-10 22:58:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/149313005/410001
6 years, 10 months ago (2014-02-10 23:54:08 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 02:14:00 UTC) #14
Message was sent while issue was closed.
Change committed as 250284

Powered by Google App Engine
This is Rietveld 408576698