Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: pkg/custom_element/lib/custom-elements.debug.js

Issue 149313004: move workaround from CE polyfill to custom elements createdCallback (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/custom_element/lib/custom-elements.debug.js
diff --git a/pkg/custom_element/lib/custom-elements.debug.js b/pkg/custom_element/lib/custom-elements.debug.js
index 6bfbb8e44df73976264803ce36e9a50c370364cb..e3c53e07d139893e849df643800b63b6396c6381 100644
--- a/pkg/custom_element/lib/custom-elements.debug.js
+++ b/pkg/custom_element/lib/custom-elements.debug.js
@@ -962,7 +962,7 @@ var hasNative = Boolean(document.registerElement);
// TODO(sorvell): See https://github.com/Polymer/polymer/issues/399
// we'll address this by defaulting to CE polyfill in the presence of the SD
// polyfill. This will avoid spamming excess attached/detached callbacks.
-// If there is a compelling need to run CE native with SD polyfill,
+// If there is a compelling need to run CE native with SD polyfill,
// we'll need to fix this issue.
var useNative = !flags.register && hasNative && !window.ShadowDOMPolyfill;
@@ -1175,11 +1175,6 @@ if (useNative) {
// getPrototypeOf(Element), we cannot do so when
// we use mixin, so we install a magic reference
customMixin(element, definition.prototype, definition.native);
-
- // Dart note: make sure we pick up the right constructor.
- // dart2js depends on this for dart:mirrors caching to work.
- // See tests/html/custom/mirrors_test.dart
- element.constructor = definition.prototype.constructor;
element.__proto__ = definition.prototype;
}
}
« no previous file with comments | « no previous file | pkg/custom_element/lib/custom-elements.min.js » ('j') | tools/dom/src/dart2js_CustomElementSupport.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698