chrome/browser/extensions/api/image_writer_private/operation_mac.cc - Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_mac.cc

Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback: Creates StartImpl function, updates platformfile lifetime to use passed ScopedPlat… Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/image_writer_private/operation_linux.cc ('K') | « chrome/browser/extensions/api/image_writer_private/operation_linux.cc ('k') | chrome/browser/extensions/api/image_writer_private/operation_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/operation_mac.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/operation_mac.cc b/chrome/browser/extensions/api/image_writer_private/operation_mac.cc

index 5aeb7f52c01488729b431ed047e8905934d7febe..2280f49974bc780700a37126b3ca0d5a79b37782 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation_mac.cc

+++ b/chrome/browser/extensions/api/image_writer_private/operation_mac.cc

@@ -8,11 +8,11 @@

namespace extensions {

namespace image_writer {

-void Operation::WriteStart() {

+void Operation::Write(const base::Closure& continuation) {

Error(error::kUnsupportedOperation);

}

-void Operation::VerifyWriteStart() {

+void Operation::VerifyWrite(const base::Closure& continuation) {

Error(error::kUnsupportedOperation);

}