chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc - Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback: Creates StartImpl function, updates platformfile lifetime to use passed ScopedPlat… Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc ('k') | chrome/browser/extensions/api/image_writer_private/image_writer_utils.h » ('j') | chrome/browser/extensions/api/image_writer_private/operation_linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

index 3d7fd423688ddbdcc07fa89df1ada1072e419dfb..357dcafffea703b5ce63c436354f681951fe9bec 100644

--- a/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

+++ b/chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc

@@ -50,7 +50,6 @@ bool ImageWriterPrivateWriteFromUrlFunction::RunImpl() {

image_writer::OperationManager::Get(GetProfile())->StartWriteFromUrl(

extension_id(),

url,

- render_view_host(),

hash,

save_image_as_download,

params->storage_unit_id,

@@ -89,11 +88,11 @@ bool ImageWriterPrivateWriteFromFileFunction::RunImpl() {

base::FilePath path;

if (!extensions::app_file_handler_util::ValidateFileEntryAndGetPath(

- filesystem_name,

- filesystem_path,

- render_view_host_,

- &path,

- &error_))

+ filesystem_name,

+ filesystem_path,

+ render_view_host(),

+ &path,

+ &error_))

return false;

image_writer::OperationManager::Get(GetProfile())->StartWriteFromFile(