Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_manager.h

Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes cross-compilation and test issues. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/operation_manager.h
diff --git a/chrome/browser/extensions/api/image_writer_private/operation_manager.h b/chrome/browser/extensions/api/image_writer_private/operation_manager.h
index 00489bcea3c853533d3a72159db74886383b3d8b..a4ea918685775aef701f4d59dfc45d48d09ef4e3 100644
--- a/chrome/browser/extensions/api/image_writer_private/operation_manager.h
+++ b/chrome/browser/extensions/api/image_writer_private/operation_manager.h
@@ -45,16 +45,14 @@ class OperationManager
// Starts a WriteFromUrl operation.
void StartWriteFromUrl(const ExtensionId& extension_id,
GURL url,
- content::RenderViewHost* rvh,
const std::string& hash,
- bool saveImageAsDownload,
- const std::string& storage_unit_id,
+ const std::string& device_path,
const Operation::StartWriteCallback& callback);
// Starts a WriteFromFile operation.
void StartWriteFromFile(const ExtensionId& extension_id,
const base::FilePath& path,
- const std::string& storage_unit_id,
+ const std::string& device_path,
const Operation::StartWriteCallback& callback);
// Cancels the extensions current operation if any.
@@ -63,7 +61,7 @@ class OperationManager
// Starts a write that removes the partition table.
void DestroyPartitions(const ExtensionId& extension_id,
- const std::string& storage_unit_id,
+ const std::string& device_path,
const Operation::StartWriteCallback& callback);
// Callback for progress events.

Powered by Google App Engine
This is Rietveld 408576698