chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc - Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc

Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes cross-compilation and test issues. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc ('k') | chrome/browser/extensions/api/image_writer_private/image_writer_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc b/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc

index 2b0fb93d9808582a14d86a3f3d62d41b81b8e56c..68a669aaad9a6ccf5856a346680ec9a337bc8371 100644

--- a/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc

+++ b/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc

@@ -12,6 +12,7 @@ namespace image_writer {

using testing::_;

using testing::AnyNumber;

+using testing::AtLeast;

namespace {

@@ -21,7 +22,7 @@ class ImageWriterDestroyPartitionsOperationTest

// Tests that the DestroyPartitionsOperation can successfully zero the first

// kPartitionTableSize bytes of an image.

-TEST_F(ImageWriterDestroyPartitionsOperationTest, DestroyPartitions) {

+TEST_F(ImageWriterDestroyPartitionsOperationTest, DestroyPartitionsEndToEnd) {

MockOperationManager manager;

base::RunLoop loop;

@@ -31,10 +32,15 @@ TEST_F(ImageWriterDestroyPartitionsOperationTest, DestroyPartitions) {

test_device_path_.AsUTF8Unsafe()));

#if defined(OS_LINUX) || defined(OS_CHROMEOS)

- EXPECT_CALL(manager, OnProgress(kDummyExtensionId, _, _)).Times(0);

EXPECT_CALL(manager, OnProgress(kDummyExtensionId,

image_writer_api::STAGE_WRITE,

_)).Times(AnyNumber());

+ EXPECT_CALL(manager,

+ OnProgress(kDummyExtensionId, image_writer_api::STAGE_WRITE, 0))

+ .Times(AtLeast(1));

+ EXPECT_CALL(manager,

+ OnProgress(kDummyExtensionId, image_writer_api::STAGE_WRITE, 100))

+ .Times(AtLeast(1));

EXPECT_CALL(manager, OnComplete(kDummyExtensionId)).Times(1);

EXPECT_CALL(manager, OnError(kDummyExtensionId, _, _, _)).Times(0);

#else