chrome/browser/extensions/api/image_writer_private/operation_manager.h - Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_manager.h

Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removes all the ScopedPlatformFileCloser stuff and just uses normal PlatformFiles. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/image_writer_private/operation_linux.cc ('K') | « chrome/browser/extensions/api/image_writer_private/operation_mac.cc ('k') | chrome/browser/extensions/api/image_writer_private/operation_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/operation_manager.h

diff --git a/chrome/browser/extensions/api/image_writer_private/operation_manager.h b/chrome/browser/extensions/api/image_writer_private/operation_manager.h

index 00489bcea3c853533d3a72159db74886383b3d8b..78c4d6350e1538bb5aa9aba55cb2d1cd86dad297 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation_manager.h

+++ b/chrome/browser/extensions/api/image_writer_private/operation_manager.h

@@ -45,16 +45,15 @@ class OperationManager

// Starts a WriteFromUrl operation.

void StartWriteFromUrl(const ExtensionId& extension_id,

GURL url,

- content::RenderViewHost* rvh,

const std::string& hash,

bool saveImageAsDownload,

- const std::string& storage_unit_id,

+ const std::string& device_path,

const Operation::StartWriteCallback& callback);

// Starts a WriteFromFile operation.

void StartWriteFromFile(const ExtensionId& extension_id,

const base::FilePath& path,

- const std::string& storage_unit_id,

+ const std::string& device_path,

const Operation::StartWriteCallback& callback);

// Cancels the extensions current operation if any.

@@ -63,7 +62,7 @@ class OperationManager

// Starts a write that removes the partition table.

void DestroyPartitions(const ExtensionId& extension_id,

- const std::string& storage_unit_id,

+ const std::string& device_path,

const Operation::StartWriteCallback& callback);

// Callback for progress events.