Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/extensions/api/image_writer_private/test_utils.h

Issue 149313003: Significantly cleans up the ImageWriter Operation class and subclasses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes compilation errors. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/image_writer_private/test_utils.h
diff --git a/chrome/browser/extensions/api/image_writer_private/test_utils.h b/chrome/browser/extensions/api/image_writer_private/test_utils.h
index b290e881ee87e86dd7096e3d1bfb981b5d9c5517..a19a48c6446e151cd809652a178b64b4525510e3 100644
--- a/chrome/browser/extensions/api/image_writer_private/test_utils.h
+++ b/chrome/browser/extensions/api/image_writer_private/test_utils.h
@@ -31,6 +31,7 @@ const int kDevicePattern = 0xAAAAAAAA; // 10101010
class MockOperationManager : public OperationManager {
public:
MockOperationManager();
+ explicit MockOperationManager(Profile* profile);
virtual ~MockOperationManager();
MOCK_METHOD3(OnProgress, void(const ExtensionId& extension_id,
@@ -57,21 +58,17 @@ class ImageWriterUnitTestBase : public testing::Test {
virtual void TearDown() OVERRIDE;
- // Compare the image and device files, returning true if they are the same,
- // false if different.
- bool CompareImageAndDevice();
-
- base::ScopedTempDir temp_dir_;
- base::FilePath test_image_path_;
- base::FilePath test_device_path_;
-
- private:
// Fills |file| with |length| bytes of |pattern|, overwriting any existing
// data.
bool FillFile(const base::FilePath& file,
const int pattern,
const int length);
+ base::ScopedTempDir temp_dir_;
+ base::FilePath test_image_path_;
+ base::FilePath test_device_path_;
+
+ private:
content::TestBrowserThreadBundle thread_bundle_;
};

Powered by Google App Engine
This is Rietveld 408576698