Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Unified Diff: chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm

Issue 149308: a bunch of bookmark bar changes (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm (revision 20198)
+++ chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm (working copy)
@@ -26,17 +26,16 @@
BookmarkBarController<BookmarkURLOpener> {
@public
scoped_nsobject<NSMutableArray> callbacks_;
-
std::vector<OpenInfo> opens_;
}
@end
@implementation FakeBookmarkBarController
-- (id)initWithProfile:(Profile*)profile
- contentArea:(NSView*)content {
+- (id)initWithProfile:(Profile*)profile view:(NSView*)view {
if ((self = [super initWithProfile:profile
- contentView:content
+ view:(BookmarkBarView*)view
+ webContentView:nil
delegate:self])) {
callbacks_.reset([[NSMutableArray alloc] init]);
}
@@ -103,9 +102,12 @@
Profile *profile = browser_test_helper_.profile();
BookmarkModel *model = profile->GetBookmarkModel();
+ scoped_nsobject<NSView> view([[NSView alloc]
+ initWithFrame:NSMakeRect(0,0,10,10)]);
+ [view.get() setHidden:YES];
scoped_nsobject<FakeBookmarkBarController>
controller([[FakeBookmarkBarController alloc] initWithProfile:profile
- contentArea:view_]);
+ view:view.get()]);
EXPECT_TRUE(controller.get());
scoped_ptr<BookmarkBarBridge> bridge(new BookmarkBarBridge(controller.get(),
model));

Powered by Google App Engine
This is Rietveld 408576698