chrome/browser/cocoa/browser_window_controller_unittest.mm - Issue 149308: a bunch of bookmark bar changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/cocoa/browser_window_controller_unittest.mm

Issue 149308: a bunch of bookmark bar changes (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/cocoa/bookmark_bar_controller_unittest.mm ('K') | « chrome/browser/cocoa/browser_window_controller.mm ('k') | chrome/browser/cocoa/toolbar_controller.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/scoped_nsobject.h"	5 #include "base/scoped_nsobject.h"

6 #include "base/scoped_nsautorelease_pool.h"	6 #include "base/scoped_nsautorelease_pool.h"

7 #include "base/scoped_ptr.h"	7 #include "base/scoped_ptr.h"

8 #include "chrome/browser/browser_process.h"	8 #include "chrome/browser/browser_process.h"

9 #include "chrome/browser/cocoa/browser_test_helper.h"	9 #include "chrome/browser/cocoa/browser_test_helper.h"

10 #include "chrome/browser/cocoa/browser_window_controller.h"	10 #include "chrome/browser/cocoa/browser_window_controller.h"

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 initWithBrowser:popup_browser.get()	88 initWithBrowser:popup_browser.get()

89 takeOwnership:NO]);	89 takeOwnership:NO]);

90 EXPECT_FALSE([controller_ isNormalWindow]);	90 EXPECT_FALSE([controller_ isNormalWindow]);

91	91

92 // The created BrowserWindowController gets autoreleased, so make	92 // The created BrowserWindowController gets autoreleased, so make

93 // sure we don't also release it.	93 // sure we don't also release it.

94 // (Confirmed with valgrind).	94 // (Confirmed with valgrind).

95 controller_.release();	95 controller_.release();

96 }	96 }

97	97

	98 TEST_F(BrowserWindowControllerTest, BookmarkBarControllerIndirection) {

	99 EXPECT_FALSE([controller_ isBookmarkBarVisible]);

	100 [controller_ toggleBookmarkBar];

	101 EXPECT_TRUE([controller_ isBookmarkBarVisible]);

	102 }

	103

98 /* TODO(???): test other methods of BrowserWindowController */	104 /* TODO(???): test other methods of BrowserWindowController */

OLD	NEW