Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1493073002: DevTools: speed up text width measure on flame chart for long strings. (Closed)

Created:
5 years ago by alph
Modified:
5 years ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: speed up text width measure on flame chart for long strings. Cut the max text length to 200 characters. Use Newton method rather than b-search to find the text length. Committed: https://crrev.com/d35b08bbc2cb28341451f344d62be3940224ea85 Cr-Commit-Position: refs/heads/master@{#363016}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment #

Total comments: 2

Patch Set 3 : 4 landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 2 3 chunks +31 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
alph
5 years ago (2015-12-02 21:52:03 UTC) #2
caseq
https://codereview.chromium.org/1493073002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/1493073002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode1469 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:1469: var m = Math.ceil(l + (r - l) * ...
5 years ago (2015-12-02 22:31:53 UTC) #3
alph
ptal https://codereview.chromium.org/1493073002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/1493073002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode1469 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:1469: var m = Math.ceil(l + (r - l) ...
5 years ago (2015-12-02 23:35:37 UTC) #4
caseq
lgtm https://codereview.chromium.org/1493073002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/1493073002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode1490 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:1490: if (text.length > 200) extract constant?
5 years ago (2015-12-03 00:01:47 UTC) #5
alph
https://codereview.chromium.org/1493073002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/1493073002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode1490 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:1490: if (text.length > 200) On 2015/12/03 00:01:46, caseq wrote: ...
5 years ago (2015-12-03 00:14:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493073002/40001
5 years ago (2015-12-03 00:16:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/74544)
5 years ago (2015-12-03 00:26:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493073002/40001
5 years ago (2015-12-03 17:38:18 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-03 18:36:02 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-03 18:37:46 UTC) #16
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d35b08bbc2cb28341451f344d62be3940224ea85
Cr-Commit-Position: refs/heads/master@{#363016}

Powered by Google App Engine
This is Rietveld 408576698