Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1493053004: Deprecate non-standard Array methods and clarify Object::isArray (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Deprecate non-standard Array methods and clarify Object::isArray BUG=none R=neis@chromium.org LOG=y Committed: https://crrev.com/e0a661fc4c50628c946a5f7a267be88c4ad161b7 Cr-Commit-Position: refs/heads/master@{#32551}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M include/v8.h View 2 chunks +7 lines, -5 lines 0 comments Download
M src/api.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-12-03 10:57:15 UTC) #1
neis
lgtm
5 years ago (2015-12-03 11:14:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493053004/20001
5 years ago (2015-12-03 11:23:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 11:44:09 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 11:45:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0a661fc4c50628c946a5f7a267be88c4ad161b7
Cr-Commit-Position: refs/heads/master@{#32551}

Powered by Google App Engine
This is Rietveld 408576698