build/config/sysroot.gni - Issue 1493043002: GN: Add an assert that sysroot exists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/sysroot.gni

Issue 1493043002: GN: Add an assert that sysroot exists (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/sysroot.gni

diff --git a/build/config/sysroot.gni b/build/config/sysroot.gni

index debf77129b4b96688a04f1a42e19910124f442f0..948054ce8d30c8540a47d1301a3262fd273bd9aa 100644

--- a/build/config/sysroot.gni

+++ b/build/config/sysroot.gni

@@ -48,6 +48,12 @@ if (current_toolchain == default_toolchain && target_sysroot != "") {

# Any other builds don't use a sysroot.

sysroot = ""

}

+ if (sysroot != "") {

+ assert(

+ exec_script("//build/dir_exists.py", [ sysroot ], "string") == "True",

+ "Missing sysroot ($sysroot). To fix, run: build/linux/sysroot_scripts/install-sysroot.py --arch=$current_cpu")

+ }

} else if (is_mac) {

import("//build/config/mac/mac_sdk.gni")

sysroot = mac_sdk_path