Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 149303004: [Telemetry] Fix flow event importer error checks (Closed)

Created:
6 years, 10 months ago by fmeawad
Modified:
6 years, 10 months ago
Reviewers:
nduca, ernstm
CC:
chromium-reviews, chrome-speed-team+watch_google.com, tfarina, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix flow event importer error checks BUG=342872 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M tools/telemetry/telemetry/core/timeline/trace_event_importer.py View 1 chunk +6 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
fmeawad
I missed a check when porting from JS to python. PTAL.
6 years, 10 months ago (2014-02-11 21:00:25 UTC) #1
nduca
lgtm
6 years, 10 months ago (2014-02-12 18:50:52 UTC) #2
fmeawad
The CQ bit was checked by fmeawad@chromium.org
6 years, 10 months ago (2014-02-12 19:23:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/149303004/1
6 years, 10 months ago (2014-02-12 19:28:08 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-12 23:25:38 UTC) #5
Message was sent while issue was closed.
Change committed as 250836

Powered by Google App Engine
This is Rietveld 408576698