[Refactor] Move the logic to update bounds for show type from WorkspaceLayoutManager to DefaultState

ash/wm/wm_types.h

Index: ash/wm/wm_types.h
diff --git a/ash/wm/wm_types.h b/ash/wm/wm_types.h
index 8a4d22df7ca269855c754c8db5d5745abe202e42..424c15826111d1fdd1c878c093bf2cbe21df0326 100644
--- a/ash/wm/wm_types.h
+++ b/ash/wm/wm_types.h
@@ -43,6 +43,24 @@ enum WindowShowType {
 
 // Set of operations that can change the window's state.
 enum WMEvent {
+  // A window is requested to become a normal state. This usually invokes
+  // restore operation with a few exceptions.

[pkotwicz, 2014/02/12 05:10:00]

How about: "A window has requsted the normal show type. This usually involves
..."

+  NORMAL,
+
+  // A window is requested to become a maximized window.

[pkotwicz, 2014/02/12 05:10:00]

How about: "A window has requested to become maximized." Similar pattern for the
others below.

[oshima, 2014/02/12 14:08:33]

Did you mean "A window has been requested" ? A window itself does not request to
be a minimized window.

+  MAXIMIZE,
+
+  // A window is requested to become a minimized window.
+  MINIMIZE,
+
+  // A window is requested to become a fullscreen window.
+  FULLSCREEN,
+
+  // A window is requested to become a left/right snapped window.
+  // TODO(oshima): Consolidate these two events.
+  SNAP_LEFT,
+  SNAP_RIGHT,

[pkotwicz, 2014/02/12 05:10:00]

I wonder whether the compound event types are worthy of being WMEvents.
I think that they can be replaced with just
VERTICAL_MAXIMIZE
HORIZONTAL_MAXIMIZE

and that you should be able to demote TOGGLE_MAXIMIZE_CAPTION, TOGGLE_MAXIMIZE
and TOGGLE_FULLSCREEN from WMEvent-hood

[oshima, 2014/02/12 14:08:33]

This is necessary to implement state machine, where the condition will be
handled in each state.

+
   // A user requested to toggle maximized state by double clicking window
   // header.
   TOGGLE_MAXIMIZE_CAPTION,
@@ -57,6 +75,9 @@ enum WMEvent {
   // A user requested to toggle horizontal maximize by double clicking
   // left/right edge.
   TOGGLE_HORIZONTAL_MAXIMIZE,
+
+  // A user requested to toggle fullscreen state.

[pkotwicz, 2014/02/12 05:44:48]

No one seems to use TOGGLE_FULLSCREEN yet. Is there a reason that you are adding
it in this CL?

[oshima, 2014/02/12 14:08:33]

Thank you for the catch. It's an error when I split the CL.
WindowState::ToggleFullscreen() now uses this.

+  TOGGLE_FULLSCREEN,
 };
 
 // Utility functions to convert WindowShowType <-> ui::WindowShowState.