ash/wm/panels/panel_layout_manager.cc - Issue 149303003: [Refactor] Move the logic to update bounds for show type from WorkspaceLayoutManager to DefaultState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/panels/panel_layout_manager.cc

Issue 149303003: [Refactor] Move the logic to update bounds for show type from WorkspaceLayoutManager to DefaultState (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/panels/panel_layout_manager.cc

diff --git a/ash/wm/panels/panel_layout_manager.cc b/ash/wm/panels/panel_layout_manager.cc

index 7bfe4ad5e207ef5213c6da373248b400e52127e3..7d7033915edf88ae53aa9ab0a091f32f37408560 100644

--- a/ash/wm/panels/panel_layout_manager.cc

+++ b/ash/wm/panels/panel_layout_manager.cc

@@ -459,7 +459,7 @@ void PanelLayoutManager::OnShelfAlignmentChanged(aura::Window* root_window) {

/////////////////////////////////////////////////////////////////////////////

// PanelLayoutManager, WindowObserver implementation:

-void PanelLayoutManager::OnWindowShowTypeChanged(

+void PanelLayoutManager::OnPreWindowShowTypeChange(

pkotwicz 2014/02/12 05:10:00 Given my suggestion about keeping WorkspaceLayoutM

wm::WindowState* window_state,

wm::WindowShowType old_type) {

// If the shelf is currently hidden then windows will not actually be shown

« ash/wm/default_state.cc ('K') | « ash/wm/panels/panel_layout_manager.h ('k') | ash/wm/resize_handle_window_targeter.h » ('j') | ash/wm/window_state.h » ('J')