Add use counters for NodeFilter being a function or an object

Add use counters for NodeFilter being a function or an object

NodeFilter is a callback interface in the spec, but a plain interface in
Blink. It's the only callback interface that also has attributes, so
that there must be a NodeFilter attribute on the global object. In order
to make NodeFilter a callback interface per spec, the bindings generator
would need new code to generate that object.

If it's possible to make the createNodeIterator() and createTreeWalker()
filter arguments callback functions instead of callback interfaces, it
looks like this could all be simplified significantly. NodeFilter would
then remain as a plain interface with only the const attributes.

There is also a minor incompatiblity with Gecko related to NodeFilter.
Blink always wraps the function or object inside a new object which is
instanceof NodeFilter, and NodeIterator.prototype.filter returns this
object. Gecko, on the other hand, returns the same object thas was
passed in to createNodeIterator(), and instanceof NodeFilter throws a
TypeError.

BUG=462946
Committed: https://crrev.com/d5996673c3f101a6dc8b2e50d9b74e32ba59a731
Cr-Commit-Position: refs/heads/master@{#363366}

[philipj_slow, 2015-12-04 15:28:17]

The CQ bit was checked by philipj@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 15:28:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493023004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493023004/1

[commit-bot: I haz the power, 2015-12-04 17:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 17:04:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[philipj_slow, 2015-12-04 19:15:33]

philipj@opera.com changed reviewers:
+ bashi@chromium.org, isherman@chromium.org

[philipj_slow, 2015-12-04 19:15:33]

PTAL. The reason I'm poking at this now is mostly because it seems pointless
trying to remove [LegacyInterfaceTypeChecking] here given that this extra
wrapper on the callback shouldn't exist per spec, and if one called ones own
callback directly with no argument or the wrong arguments, it wouldn't throw
TypeError.

[bashi, 2015-12-05 02:06:01]

bindings/ LGTM

[Ilya Sherman, 2015-12-05 02:34:41]

histograms.xml lgtm

[philipj_slow, 2015-12-05 07:22:33]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-12-05 07:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493023004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493023004/1

[commit-bot: I haz the power, 2015-12-05 09:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 09:25:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[haraken, 2015-12-05 09:46:51]

bindings LGTM

[philipj_slow, 2015-12-05 11:33:44]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-12-05 11:34:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493023004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493023004/1

[commit-bot: I haz the power, 2015-12-05 13:35:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 13:35:19]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)

[philipj_slow, 2015-12-05 18:54:49]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-12-05 18:55:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493023004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493023004/1

[commit-bot: I haz the power, 2015-12-05 20:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-05 20:37:20]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[philipj_slow, 2015-12-06 10:10:32]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2015-12-06 10:10:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493023004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493023004/1

[commit-bot: I haz the power, 2015-12-06 11:04:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-06 11:04:50]

Description was changed from

==========
Add use counters for NodeFilter being a function or an object

NodeFilter is a callback interface in the spec, but a plain interface in
Blink. It's the only callback interface that also has attributes, so
that there must be a NodeFilter attribute on the global object. In order
to make NodeFilter a callback interface per spec, the bindings generator
would need new code to generate that object.

If it's possible to make the createNodeIterator() and createTreeWalker()
filter arguments callback functions instead of callback interfaces, it
looks like this could all be simplified significantly. NodeFilter would
then remain as a plain interface with only the const attributes.

There is also a minor incompatiblity with Gecko related to NodeFilter.
Blink always wraps the function or object inside a new object which is
instanceof NodeFilter, and NodeIterator.prototype.filter returns this
object. Gecko, on the other hand, returns the same object thas was
passed in to createNodeIterator(), and instanceof NodeFilter throws a
TypeError.

BUG=462946
==========

to

==========
Add use counters for NodeFilter being a function or an object

NodeFilter is a callback interface in the spec, but a plain interface in
Blink. It's the only callback interface that also has attributes, so
that there must be a NodeFilter attribute on the global object. In order
to make NodeFilter a callback interface per spec, the bindings generator
would need new code to generate that object.

If it's possible to make the createNodeIterator() and createTreeWalker()
filter arguments callback functions instead of callback interfaces, it
looks like this could all be simplified significantly. NodeFilter would
then remain as a plain interface with only the const attributes.

There is also a minor incompatiblity with Gecko related to NodeFilter.
Blink always wraps the function or object inside a new object which is
instanceof NodeFilter, and NodeIterator.prototype.filter returns this
object. Gecko, on the other hand, returns the same object thas was
passed in to createNodeIterator(), and instanceof NodeFilter throws a
TypeError.

BUG=462946

Committed: https://crrev.com/d5996673c3f101a6dc8b2e50d9b74e32ba59a731
Cr-Commit-Position: refs/heads/master@{#363366}
==========

[commit-bot: I haz the power, 2015-12-06 11:04:51]

Patchset 1 (id:??) landed as
https://crrev.com/d5996673c3f101a6dc8b2e50d9b74e32ba59a731
Cr-Commit-Position: refs/heads/master@{#363366}