Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1493023002: Add documentation warning about chrome://* in URLBlacklist policy. (Closed)

Created:
5 years ago by Thiemo Nagel
Modified:
5 years ago
Reviewers:
cschuet (SLOW), dskaram
CC:
chromium-reviews, tnagel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add documentation warning about chrome://* in URLBlacklist policy. BUG=529891 Committed: https://crrev.com/03dcfb8b8f01525ea02671efbce203025e4fb6ae Cr-Commit-Position: refs/heads/master@{#362963}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/policy/resources/policy_templates.json View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Thiemo Nagel
Hi David, updating documentation as discussed on the bug. Could you please take a quick ...
5 years ago (2015-12-02 20:47:53 UTC) #2
Thiemo Nagel
Hi Christoph, could you please rubber-stamp? David has approved the wording in email conversation. Cheers, ...
5 years ago (2015-12-03 11:25:33 UTC) #4
cschuet (SLOW)
On 2015/12/03 11:25:33, Thiemo Nagel wrote: > Hi Christoph, > > could you please rubber-stamp? ...
5 years ago (2015-12-03 11:27:49 UTC) #5
Thiemo Nagel
> LGTM Thank you!
5 years ago (2015-12-03 11:51:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493023002/20001
5 years ago (2015-12-03 11:52:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 12:50:46 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 12:51:34 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/03dcfb8b8f01525ea02671efbce203025e4fb6ae
Cr-Commit-Position: refs/heads/master@{#362963}

Powered by Google App Engine
This is Rietveld 408576698