Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2091)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 1493013002: cc: Force commit on the frame after a copy request (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to LayerTreeHost Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 0ce5d0e0cf526aa3885d15b1aba47b2cf9d0584c..2f456ade9e4485b8827d901d383353ef8a354b20 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -1067,6 +1067,14 @@ DrawResult LayerTreeHostImpl::CalculateRenderPasses(
// trigger this DCHECK.
DCHECK(!have_copy_request || draw_result == DRAW_SUCCESS);
+ // Workaround to prevent creating unnecessarily persistent render passes.
+ // When a copy request is made, it may force a separate render pass for the
+ // web contents, which will persist until a new commit removes it. Force a
danakj 2015/12/02 23:07:52 s/web contents/layer/
+ // commit after copy requests, to remove extra render passes.
+ // http://crbug.com/564832
danakj 2015/12/02 23:07:52 prefix this whole comment with TODO(crbug.com/5648
+ if (have_copy_request)
+ client_->SetNeedsCommitOnImplThread();
+
return draw_result;
}
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_unittest_copyrequest.cc » ('j') | cc/trees/layer_tree_host_unittest_copyrequest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698