Support enclosing fragmentainer breaks inside spanners.

Support enclosing fragmentainer breaks inside spanners.

A column-span:all object in a nested multicol container is part of one or more
columns in the outer multicol container, so we need to allow it to be
paginated. In order to paginate it correctly, we also need to set its correct
logical top before laying it out, or we'd risk inserting pagination struts at
the wrong places.

BUG=447718
R=leviw@chromium.org

Committed: https://crrev.com/ba02d22e594ec2a719c499c988a3e049353ef9cd
Cr-Commit-Position: refs/heads/master@{#363160}

[mstensho (USE GERRIT), 2015-12-02 20:00:04]

This was horribly broken, but also horribly easy to fix. :)

[leviw_travelin_and_unemployed, 2015-12-03 23:08:59]

The CQ bit was checked by leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-12-03 23:08:59]

lgtm

I'm a bit under the weather so I'm moving slower than usual.

As far as I'm concerned, you're Mr. Beer.

You're having too much fun with this, aren't you ;)

[commit-bot: I haz the power, 2015-12-03 23:10:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492993002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492993002/1

[commit-bot: I haz the power, 2015-12-04 01:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 01:19:18]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  android_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[mstensho (USE GERRIT), 2015-12-04 07:12:37]

On 2015/12/03 23:08:59, leviw wrote:
> lgtm
> 
> I'm a bit under the weather so I'm moving slower than usual.

Feel better soon! Hope some spanner beer helps.

> As far as I'm concerned, you're Mr. Beer.
> 
> You're having too much fun with this, aren't you ;)

Not sure if having too much fun or just going insane.

[mstensho (USE GERRIT), 2015-12-04 07:12:53]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2015-12-04 07:13:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492993002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492993002/1

[commit-bot: I haz the power, 2015-12-04 07:17:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-04 07:19:05]

Description was changed from

==========
Support enclosing fragmentainer breaks inside spanners.

A column-span:all object in a nested multicol container is part of one or more
columns in the outer multicol container, so we need to allow it to be
paginated. In order to paginate it correctly, we also need to set its correct
logical top before laying it out, or we'd risk inserting pagination struts at
the wrong places.

BUG=447718
R=leviw@chromium.org
==========

to

==========
Support enclosing fragmentainer breaks inside spanners.

A column-span:all object in a nested multicol container is part of one or more
columns in the outer multicol container, so we need to allow it to be
paginated. In order to paginate it correctly, we also need to set its correct
logical top before laying it out, or we'd risk inserting pagination struts at
the wrong places.

BUG=447718
R=leviw@chromium.org

Committed: https://crrev.com/ba02d22e594ec2a719c499c988a3e049353ef9cd
Cr-Commit-Position: refs/heads/master@{#363160}
==========

[commit-bot: I haz the power, 2015-12-04 07:19:06]

Patchset 1 (id:??) landed as
https://crrev.com/ba02d22e594ec2a719c499c988a3e049353ef9cd
Cr-Commit-Position: refs/heads/master@{#363160}