Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 1492943005: Remove ShutdownIPCSupportAndWaitForNoChannels. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ShutdownIPCSupportAndWaitForNoChannels. It's going to be very difficult to enable this for production code as any code can leak message pipes. It'll also be hard to implement correctly with multiplexing. This was added for a test, but I just changed the test instead so that it quits after it sends a lot of reply messages. BUG=556259 Committed: https://crrev.com/7643332bff3b1557139f5fbbe82588eb329c546b Cr-Commit-Position: refs/heads/master@{#363034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -62 lines) Patch
M mojo/edk/embedder/embedder.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/edk/embedder/embedder.cc View 3 chunks +6 lines, -42 lines 0 comments Download
M mojo/edk/embedder/embedder_internal.h View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/raw_channel.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/edk/system/raw_channel_win.cc View 4 chunks +7 lines, -2 lines 0 comments Download
M mojo/edk/system/run_all_unittests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/test/scoped_ipc_support.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jam
5 years ago (2015-12-03 16:59:54 UTC) #2
yzshen1
lgtm
5 years ago (2015-12-03 18:08:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492943005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492943005/20001
5 years ago (2015-12-03 18:28:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years ago (2015-12-03 19:38:58 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 19:39:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7643332bff3b1557139f5fbbe82588eb329c546b
Cr-Commit-Position: refs/heads/master@{#363034}

Powered by Google App Engine
This is Rietveld 408576698