Allow replacing the HttpAuthHandlerFactory in URLRequestContextBuilder

android_webview/browser/net/aw_url_request_context_getter.cc

Index: android_webview/browser/net/aw_url_request_context_getter.cc
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index 7e39d1cdae1b006c68b4e4d63d97634372f23cc0..b8d4ce636293f0ed6d6166cc19821af0e61adafb 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -225,9 +225,8 @@ void AwURLRequestContextGetter::InitializeURLRequestContext() {
   scoped_ptr<net::MappedHostResolver> host_resolver(new net::MappedHostResolver(
       net::HostResolver::CreateDefaultResolver(nullptr)));
   ApplyCmdlineOverridesToHostResolver(host_resolver.get());
-  builder.add_http_auth_handler_factory(
-      "negotiate",
-      CreateNegotiateAuthHandlerFactory(host_resolver.get()).release());
+  builder.SetHttpAuthHandlerFactory(
+      CreateAuthHandlerFactory(host_resolver.get()).Pass());
   builder.set_host_resolver(host_resolver.Pass());
 
   url_request_context_ = builder.Build().Pass();
@@ -273,18 +272,19 @@ void AwURLRequestContextGetter::SetKeyOnIO(const std::string& key) {
 }
 
 scoped_ptr<net::HttpAuthHandlerFactory>
-AwURLRequestContextGetter::CreateNegotiateAuthHandlerFactory(
+AwURLRequestContextGetter::CreateAuthHandlerFactory(
     net::HostResolver* resolver) {
   DCHECK(resolver);
-  std::vector<std::string> supported_schemes = {"negotiate"};
+
+  // TODO(dgn) In Chrome this is configurable via the AuthSchemes policy.
+  // For WebView there is no interest to have it available so far.

[asanka, 2015/12/05 03:16:35]

Why is this a TODO?

[dgn, 2015/12/07 11:15:00]

It's not, removed the todo mention

+  std::vector<std::string> supported_schemes = {"basic", "digest", "negotiate"};
   http_auth_preferences_.reset(new net::HttpAuthPreferences(supported_schemes));
   http_auth_preferences_->set_server_whitelist(auth_server_whitelist_);
   http_auth_preferences_->set_auth_android_negotiate_account_type(
       auth_android_negotiate_account_type_);
-  scoped_ptr<net::HttpAuthHandlerFactory> negotiate_factory(
-      net::HttpAuthHandlerRegistryFactory::Create(http_auth_preferences_.get(),
-                                                  resolver));
-  return negotiate_factory;
+  return net::HttpAuthHandlerRegistryFactory::Create(
+      http_auth_preferences_.get(), resolver);
 }
 
 }  // namespace android_webview