Allow replacing the HttpAuthHandlerFactory in URLRequestContextBuilder

Allow replacing the HttpAuthHandlerFactory in URLRequestContextBuilder

Replace add_extra_http_auth_handler_factory by
set_http_auth_handler_factory, that allows completely replacing
the factory rather than specifying add-ons to the one created
by the builder.

BUG=533513
Committed: https://crrev.com/7fae2af63bb6cd6e6b79c7ee27693c552e092d4a
Cr-Commit-Position: refs/heads/master@{#363509}

[dgn, 2015-12-02 19:06:30]

dgn@chromium.org changed reviewers:
+ asanka@chromium.org, sgurun@chromium.org

[dgn, 2015-12-02 19:06:30]

sgurun@chromium.org: Please review changes in
//android_webview/.../aw_url_request_context_getter.*

asanka@chromium.org: Please review changes in
//net/.../url_request_context_builder*

This is a follow up to the previous CL, to address the extra
HttpAuthHandlerFactory creation

[sgurun-gerrit only, 2015-12-03 23:14:26]

On 2015/12/02 19:06:30, dgn wrote:
> mailto:sgurun@chromium.org: Please review changes in
> //android_webview/.../aw_url_request_context_getter.*
> 
> mailto:asanka@chromium.org: Please review changes in
> //net/.../url_request_context_builder*
> 
> This is a follow up to the previous CL, to address the extra
> HttpAuthHandlerFactory creation

I don't see any issues at the webview side, let's see what asanka says though.

[asanka, 2015-12-05 03:16:35]

LGTM. Thanks!

https://codereview.chromium.org/1492943002/diff/40001/android_webview/browser...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/1492943002/diff/40001/android_webview/browser...
android_webview/browser/net/aw_url_request_context_getter.cc:280: // For WebView
there is no interest to have it available so far.
Why is this a TODO?

[dgn, 2015-12-07 11:15:00]

sgurun@ PTAL

https://codereview.chromium.org/1492943002/diff/40001/android_webview/browser...
File android_webview/browser/net/aw_url_request_context_getter.cc (right):

https://codereview.chromium.org/1492943002/diff/40001/android_webview/browser...
android_webview/browser/net/aw_url_request_context_getter.cc:280: // For WebView
there is no interest to have it available so far.
On 2015/12/05 03:16:35, asanka wrote:
> Why is this a TODO?

It's not, removed the todo mention

[sgurun-gerrit only, 2015-12-07 17:40:45]

lgtm

[dgn, 2015-12-07 17:51:33]

On 2015/12/07 17:40:45, sgurun wrote:
> lgtm

Thanks!

[dgn, 2015-12-07 17:51:39]

The CQ bit was checked by dgn@chromium.org

[dgn, 2015-12-07 17:51:40]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/1492943002/#ps60001
(title: "Not a todo")

[commit-bot: I haz the power, 2015-12-07 17:53:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492943002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492943002/60001

[commit-bot: I haz the power, 2015-12-07 17:59:46]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-07 18:00:47]

Description was changed from

==========
Allow replacing the HttpAuthHandlerFactory in URLRequestContextBuilder

Replace add_extra_http_auth_handler_factory by
set_http_auth_handler_factory, that allows completely replacing
the factory rather than specifying add-ons to the one created
by the builder.

BUG=533513
==========

to

==========
Allow replacing the HttpAuthHandlerFactory in URLRequestContextBuilder

Replace add_extra_http_auth_handler_factory by
set_http_auth_handler_factory, that allows completely replacing
the factory rather than specifying add-ons to the one created
by the builder.

BUG=533513

Committed: https://crrev.com/7fae2af63bb6cd6e6b79c7ee27693c552e092d4a
Cr-Commit-Position: refs/heads/master@{#363509}
==========

[commit-bot: I haz the power, 2015-12-07 18:00:48]

Patchset 4 (id:??) landed as
https://crrev.com/7fae2af63bb6cd6e6b79c7ee27693c552e092d4a
Cr-Commit-Position: refs/heads/master@{#363509}