Generate localizable string resources for Android Chromoting

Generate localizable string resources for Android Chromoting

This localizes just the application name (so that Official builds of
the Android app will be called "Chrome Remote Desktop"). Followup CLs
will make the remaining strings localizable.

BUG=270362
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248899

[Jamie, 2014-01-29 18:44:11]

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:336: <message desc="The product name.
Displayed in various Chrome pages, including the New Tab page, and displayed
prominently on the app's main page." name="IDS_PRODUCT_NAME"
formatter_data="android_java android_java_name=app_name">
If I'm understanding this correctly, app_name is what this string is called in
the Android code. We should at least make sure that the names match (in this
case, it should be product_name, not app_name), and I'd ideally like for us not
to have to specify formatter_data at all (it's just duplicated definitions which
will be prone to copy-paste errors).

I don't think I'm a good choice of reviewer for this CL. I don't know anything
about the internals of gyp, so I can't say whether or not there's a simpler
approach.

[Sergey Ulanov, 2014-01-30 07:19:41]

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:240: <message desc="The product name.
Displayed in various Chrome pages, including the New Tab page, and displayed
prominently on the app's main page." name="IDS_PRODUCT_NAME"
formatter_data="android_java android_java_name=app_name">
Maybe instead of using android_java_name repace app_name with product_name in
remoting/android/java/AndroidManifest.xml?

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:240: <message desc="The product name.
Displayed in various Chrome pages, including the New Tab page, and displayed
prominently on the app's main page." name="IDS_PRODUCT_NAME"
formatter_data="android_java android_java_name=app_name">
Why do you need android_java. If I understand it correctly, this flag only
applies when you are specifying ANDROID_JAVA_TAGGED_ONLY env when processing grd
file. It's useful only if you want to exclude all other strings. But I think we
will need most of the other strings.

[Lambros, 2014-02-04 03:42:36]

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:240: <message desc="The product name.
Displayed in various Chrome pages, including the New Tab page, and displayed
prominently on the app's main page." name="IDS_PRODUCT_NAME"
formatter_data="android_java android_java_name=app_name">
On 2014/01/30 07:19:42, Sergey Ulanov wrote:
> Maybe instead of using android_java_name repace app_name with product_name in
> remoting/android/java/AndroidManifest.xml?

I just assumed that "app_name" was forced by the Android framework, and didn't
realize there was this other level of indirection! Done.

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:240: <message desc="The product name.
Displayed in various Chrome pages, including the New Tab page, and displayed
prominently on the app's main page." name="IDS_PRODUCT_NAME"
formatter_data="android_java android_java_name=app_name">
On 2014/01/30 07:19:42, Sergey Ulanov wrote:
> Why do you need android_java. If I understand it correctly, this flag only
> applies when you are specifying ANDROID_JAVA_TAGGED_ONLY env when processing
grd
> file. It's useful only if you want to exclude all other strings. But I think
we
> will need most of the other strings.

The Chrome default for processing GRD files is to set
ANDROID_JAVA_TAGGED_ONLY=true - this is set from build/common.gypi. We could
override this, but we have lots of host-related strings that aren't relevant to
Android, so I'm not convinced of the value of including everything.

UPDATE: It doesn't work anyway. I get a bunch of formatting failures like this:
     [aapt]
my-chrome-dir/src/out/Debug/gen/remoting/android/res/values-am/remoting_strings.xml:141:
error: Multiple substitutions specified in non-positional format; did you mean
to add the formatted="false" attribute?

https://codereview.chromium.org/149293002/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:336: <message desc="The product name.
Displayed in various Chrome pages, including the New Tab page, and displayed
prominently on the app's main page." name="IDS_PRODUCT_NAME"
formatter_data="android_java android_java_name=app_name">
On 2014/01/29 18:44:11, Jamie wrote:
> If I'm understanding this correctly, app_name is what this string is called in
> the Android code. We should at least make sure that the names match (in this
> case, it should be product_name, not app_name), and I'd ideally like for us
not
> to have to specify formatter_data at all (it's just duplicated definitions
which
> will be prone to copy-paste errors).
> 
> I don't think I'm a good choice of reviewer for this CL. I don't know anything
> about the internals of gyp, so I can't say whether or not there's a simpler
> approach.

Done.

[Sergey Ulanov, 2014-02-04 23:35:30]

lgtm

[Lambros, 2014-02-05 01:26:17]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-02-05 03:51:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/149293002/...

[commit-bot: I haz the power, 2014-02-05 07:23:56]

Change committed as 248899