Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/lookup.cc

Issue 1492923002: [proxies] do not leak private symbols to proxy traps (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move check to LookupIterator Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies-get.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index be0edaa3a27b965c2d46882c8908b39c78d7c112..3b953c9d71f7f70f1c37ffc3d760740d8d316c2c 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -609,7 +609,10 @@ LookupIterator::State LookupIterator::LookupInHolder(Map* const map,
}
switch (state_) {
case NOT_FOUND:
- if (map->IsJSProxyMap()) return JSPROXY;
+ if (map->IsJSProxyMap()) {
+ if (!name_.is_null() && name_->IsPrivate()) return NOT_FOUND;
+ return JSPROXY;
+ }
if (map->is_access_check_needed() &&
(IsElement() || !isolate_->IsInternallyUsedPropertyName(name_))) {
return ACCESS_CHECK;
« no previous file with comments | « no previous file | test/mjsunit/harmony/proxies-get.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698