components/gcm_driver/gcm_client_impl.cc - Issue 1492913002: Add command line overrides for GCM checkin URL & MCS endpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client_impl.cc

Issue 1492913002: Add command line overrides for GCM checkin URL & MCS endpoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/gcm_client_impl.cc

diff --git a/components/gcm_driver/gcm_client_impl.cc b/components/gcm_driver/gcm_client_impl.cc

index 9c4c6ad05870240443ce628a43c06e39c7337fb6..fb871e0ba57c2c110d90c1f06b9ec91cba303f5e 100644

--- a/components/gcm_driver/gcm_client_impl.cc

+++ b/components/gcm_driver/gcm_client_impl.cc

@@ -479,6 +479,8 @@ void GCMClientImpl::InitializeMCSClient() {

std::vector<GURL> endpoints;

endpoints.push_back(gservices_settings_.GetMCSMainEndpoint());

endpoints.push_back(gservices_settings_.GetMCSFallbackEndpoint());

+ if (endpoints[1].is_empty())

Nicolas Zea 2015/12/02 19:48:21 nit: I think it would be cleaner to do GURL fallba

johnme 2015/12/03 12:22:49 Done.

+ endpoints.pop_back();

connection_factory_ = internals_builder_->BuildConnectionFactory(

endpoints,

GetGCMBackoffPolicy(),

« no previous file with comments | « no previous file | google_apis/gcm/engine/gservices_settings.h » ('j') | no next file with comments »