[proxies] Make Object.prototype.isPrototypeOf work with proxies.

[proxies] Make Object.prototype.isPrototypeOf step into proxies.

R=rossberg, verwaest@chromium.org
BUG=v8:1543
LOG=n

Committed: https://crrev.com/4ca1180d2e7c409312ae0761cb12843989466573
Cr-Commit-Position: refs/heads/master@{#32569}

[Toon Verwaest, 2015-12-03 11:29:02]

https://codereview.chromium.org/1492863002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1492863002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1382: Maybe<bool> maybe =
Object::HasInPrototypeChain(isolate, obj, filter);
Debug methods are not supposed to have side-effects.

[Toon Verwaest, 2015-12-03 11:30:33]

https://codereview.chromium.org/1492863002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1492863002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1382: Maybe<bool> maybe =
Object::HasInPrototypeChain(isolate, obj, filter);
On 2015/12/03 11:29:02, Toon Verwaest wrote:
> Debug methods are not supposed to have side-effects.

Plus we are iterating the heap. Allocating here could be pretty bad.

[neis, 2015-12-03 12:58:07]

On 2015/12/03 11:30:33, Toon Verwaest wrote:
> https://codereview.chromium.org/1492863002/diff/1/src/runtime/runtime-debug.cc
> File src/runtime/runtime-debug.cc (right):
> 
>
https://codereview.chromium.org/1492863002/diff/1/src/runtime/runtime-debug.c...
> src/runtime/runtime-debug.cc:1382: Maybe<bool> maybe =
> Object::HasInPrototypeChain(isolate, obj, filter);
> On 2015/12/03 11:29:02, Toon Verwaest wrote:
> > Debug methods are not supposed to have side-effects.
> 
> Plus we are iterating the heap. Allocating here could be pretty bad.

Changed runtime-debug.cc back to the old semantics.

[Toon Verwaest, 2015-12-03 14:33:18]

lgtm

[neis, 2015-12-03 14:37:29]

Description was changed from

==========
[proxies] Make Object.prototype.isPrototypeOf work with proxies.

R=rossberg, verwaest@chromium.org
BUG=
==========

to

==========
[proxies] Make Object.prototype.isPrototypeOf step into proxies.

R=rossberg, verwaest@chromium.org
BUG=v8:1543
LOG=n
==========

[neis, 2015-12-03 14:37:35]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2015-12-03 14:37:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492863002/20001

[commit-bot: I haz the power, 2015-12-03 15:03:20]

Description was changed from

==========
[proxies] Make Object.prototype.isPrototypeOf step into proxies.

R=rossberg, verwaest@chromium.org
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Make Object.prototype.isPrototypeOf step into proxies.

R=rossberg, verwaest@chromium.org
BUG=v8:1543
LOG=n
==========

[commit-bot: I haz the power, 2015-12-03 15:03:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 15:03:31]

Description was changed from

==========
[proxies] Make Object.prototype.isPrototypeOf step into proxies.

R=rossberg, verwaest@chromium.org
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Make Object.prototype.isPrototypeOf step into proxies.

R=rossberg, verwaest@chromium.org
BUG=v8:1543
LOG=n

Committed: https://crrev.com/4ca1180d2e7c409312ae0761cb12843989466573
Cr-Commit-Position: refs/heads/master@{#32569}
==========

[commit-bot: I haz the power, 2015-12-03 15:03:32]

Patchset 2 (id:??) landed as
https://crrev.com/4ca1180d2e7c409312ae0761cb12843989466573
Cr-Commit-Position: refs/heads/master@{#32569}

[Michael Achenbach, 2015-12-03 20:23:36]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1494283002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for:
https://uberchromegw.corp.google.com/i/client.v8.fyi/builders/V8-Blink%20Linu...

Can just be relanded if it doesn't get green..