Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 1492843006: get_concurrent_links.py: give more RAM per job in LTO builds. (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

get_concurrent_links.py: give more RAM per job in LTO builds. This is required for launching Control Flow Integrity on Linux x86-64, as it uses LTO builds, which use significantly more memory during link phase. Failing to do that lead me to see this OOM error message on the bot: https://chromegw.corp.google.com/i/official.desktop/builders/precise64/builds/253 BUG=565162, 464797 Committed: https://crrev.com/8b2f896b9b2083ced0a42879ef6ea427a3cd56d4 Cr-Commit-Position: refs/heads/master@{#363137}

Patch Set 1 #

Patch Set 2 : fmt #

Total comments: 4

Patch Set 3 : nits #

Patch Set 4 : win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M build/toolchain/gcc_toolchain.gni View 1 chunk +6 lines, -1 line 0 comments Download
M build/toolchain/get_concurrent_links.py View 1 2 3 chunks +19 lines, -3 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 29 (12 generated)
krasin
5 years ago (2015-12-03 23:16:30 UTC) #2
krasin
https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/gcc_toolchain.gni File build/toolchain/gcc_toolchain.gni (right): https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/gcc_toolchain.gni#newcode13 build/toolchain/gcc_toolchain.gni:13: concurrent_links = I am not totally sure, if it's ...
5 years ago (2015-12-03 23:18:45 UTC) #4
Dirk Pranke
lgtm w/ nits. thanks! https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/get_concurrent_links.py File build/toolchain/get_concurrent_links.py (right): https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/get_concurrent_links.py#newcode14 build/toolchain/get_concurrent_links.py:14: def GetDefaultConcurrentLinks(is_lto=False): nit: don't specify ...
5 years ago (2015-12-03 23:19:09 UTC) #6
Dirk Pranke
On 2015/12/03 23:18:45, krasin wrote: > https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/gcc_toolchain.gni > File build/toolchain/gcc_toolchain.gni (right): > > https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/gcc_toolchain.gni#newcode13 > ...
5 years ago (2015-12-03 23:20:22 UTC) #7
krasin
https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/gcc_toolchain.gni File build/toolchain/gcc_toolchain.gni (right): https://codereview.chromium.org/1492843006/diff/20001/build/toolchain/gcc_toolchain.gni#newcode13 build/toolchain/gcc_toolchain.gni:13: concurrent_links = On 2015/12/03 23:18:45, krasin wrote: > I ...
5 years ago (2015-12-03 23:22:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492843006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492843006/40001
5 years ago (2015-12-03 23:24:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492843006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492843006/60001
5 years ago (2015-12-03 23:27:50 UTC) #15
krasin
Dirk, I have also added the same change to the Windows toolchain BUILD.gn. I think ...
5 years ago (2015-12-03 23:28:19 UTC) #16
Dirk Pranke
On 2015/12/03 23:28:19, krasin wrote: > Dirk, > > I have also added the same ...
5 years ago (2015-12-03 23:42:00 UTC) #17
krasin
On 2015/12/03 23:42:00, Dirk Pranke wrote: > On 2015/12/03 23:28:19, krasin wrote: > > Dirk, ...
5 years ago (2015-12-03 23:49:51 UTC) #18
Dirk Pranke
I'm fine w/ leaving this in for consistency, since my understanding is that we will ...
5 years ago (2015-12-03 23:52:02 UTC) #19
Dirk Pranke
On 2015/12/03 23:52:02, Dirk Pranke wrote: > I'm fine w/ leaving this in for consistency, ...
5 years ago (2015-12-03 23:52:20 UTC) #20
krasin
On 2015/12/03 23:52:20, Dirk Pranke wrote: > On 2015/12/03 23:52:02, Dirk Pranke wrote: > > ...
5 years ago (2015-12-03 23:55:43 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
5 years ago (2015-12-04 01:40:26 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492843006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492843006/60001
5 years ago (2015-12-04 04:39:26 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-04 04:45:24 UTC) #27
commit-bot: I haz the power
5 years ago (2015-12-04 04:46:06 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8b2f896b9b2083ced0a42879ef6ea427a3cd56d4
Cr-Commit-Position: refs/heads/master@{#363137}

Powered by Google App Engine
This is Rietveld 408576698