Issue 1492843003: Don't attempt to create a file for non-Dart imports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1492843003: Don't attempt to create a file for non-Dart imports. (Closed)

Created:
5 years ago by scheglov

Modified:
5 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't attempt to create a file for non-Dart imports. This should help to fix the following exception: Dart analysis server, SDK version 1.13.0-dev.7.12, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor Bad state: No element R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bf54a3bef6e02453508253ce6c1b6b719461ec0b

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	pkg/analysis_server/test/services/correction/fix_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

5 years ago (2015-12-02 17:29:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bf54a3bef6e02453508253ce6c1b6b719461ec0b (presubmit successful).