Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1492823007: Fix #25111: evaluate arguments before throwing errors about invoking invalid constructors (Closed)

Created:
5 years ago by Siggi Cherem (dart-lang)
Modified:
5 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix #25111: evaluate arguments before throwing errors about invoking invalid constructors BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/bb2c3a9350eec6cedb88b8f879d3626edadcfeb3

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Siggi Cherem (dart-lang)
5 years ago (2015-12-04 02:35:20 UTC) #4
sra1
lgtm
5 years ago (2015-12-04 20:59:46 UTC) #5
Siggi Cherem (dart-lang)
5 years ago (2015-12-04 21:33:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
bb2c3a9350eec6cedb88b8f879d3626edadcfeb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698