tools/gn: forward declare some base types in trace.h

tools/gn: forward declare some base types in trace.h

CommandLine and FilePath are being passed by reference, so they can be
forward declared and their header includes be moved to the source file
instead.

BUG=None
TEST=gn gen + gn_unittests
R=scottmg@chromium.org

Committed: https://crrev.com/7741ab4958dec364e2d5f43d678bda53fc2465fa
Cr-Commit-Position: refs/heads/master@{#363056}

[tfarina, 2015-12-03 12:04:23]

Scott, ping?

[scottmg, 2015-12-03 15:16:47]

I don't really think this is worth doing. You can try to convince Brett if you
like. :)

[tfarina, 2015-12-03 15:50:24]

tfarina@chromium.org changed reviewers:
+ brettw@chromium.org

[tfarina, 2015-12-03 15:50:25]

+Brett!

I think we should forward whenever we can.

[brettw, 2015-12-03 17:56:23]

This is fine since you've already bothered doing the patch and sending it out,
LGTM. But I would not bother looking for this kind of thing in the future. I
think there's a code churn and time sink aspect to this that's not worth the
benefit except for some really common/big files in base or content or something.

[tfarina, 2015-12-03 19:40:33]

On 2015/12/03 17:56:23, brettw wrote:
> This is fine since you've already bothered doing the patch and sending it out,
> LGTM. But I would not bother looking for this kind of thing in the future. I
> think there's a code churn and time sink aspect to this that's not worth the
> benefit except for some really common/big files in base or content or
something.

OK. Thanks, point taken!

[tfarina, 2015-12-03 19:40:39]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-12-03 19:43:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1492813002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1492813002/1

[commit-bot: I haz the power, 2015-12-03 21:07:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-03 21:08:07]

Description was changed from

==========
tools/gn: forward declare some base types in trace.h

CommandLine and FilePath are being passed by reference, so they can be
forward declared and their header includes be moved to the source file
instead.

BUG=None
TEST=gn gen + gn_unittests
R=scottmg@chromium.org
==========

to

==========
tools/gn: forward declare some base types in trace.h

CommandLine and FilePath are being passed by reference, so they can be
forward declared and their header includes be moved to the source file
instead.

BUG=None
TEST=gn gen + gn_unittests
R=scottmg@chromium.org

Committed: https://crrev.com/7741ab4958dec364e2d5f43d678bda53fc2465fa
Cr-Commit-Position: refs/heads/master@{#363056}
==========

[commit-bot: I haz the power, 2015-12-03 21:08:07]

Patchset 1 (id:??) landed as
https://crrev.com/7741ab4958dec364e2d5f43d678bda53fc2465fa
Cr-Commit-Position: refs/heads/master@{#363056}