third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp - Issue 1492763002: Add a utility class to call stream methods implemented with v8 extras.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

Issue 1492763002: Add a utility class to call stream methods implemented with v8 extras. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-extra-switch

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptState.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8BindingMacros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

index f2664392f3022f3efbf9c31d3710588a46a07f41..6bcb4fd878038e515e3c2516434604a813bfdbca 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp

@@ -102,6 +102,15 @@ ScriptValue ScriptState::getFromGlobalObject(const char* name)

return ScriptValue(this, v8Value);

}

+ScriptValue ScriptState::getFromExtrasExports(const char* name)

+ v8::HandleScope handleScope(m_isolate);

+ v8::Local<v8::Value> v8Value;

+ if (!context()->GetExtrasBindingObject()->Get(context(), v8AtomicString(isolate(), name)).ToLocal(&v8Value))

+ return ScriptValue();

+ return ScriptValue(this, v8Value);

ExecutionContext* ScriptState::executionContext() const

{

v8::HandleScope scope(m_isolate);