Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 149273005: Remove the logic to recreate stream texture for MSE video (Closed)

Created:
6 years, 10 months ago by qinmin
Modified:
6 years, 10 months ago
Reviewers:
no sievers
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Remove the logic to recreate stream texture for MSE video We now hold the surface inside MediaSourcePlayer. So when a new MediaCodec is recreated, we reuse the same surface object. As a result, we no longer need to recreate the stream texture for each MediaCodec. BUG=339191 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qinmin
PTAL
6 years, 10 months ago (2014-01-30 02:36:36 UTC) #1
no sievers
lgtm, thanks for testing this out!
6 years, 10 months ago (2014-02-06 02:09:14 UTC) #2
qinmin
The CQ bit was checked by qinmin@chromium.org
6 years, 10 months ago (2014-02-18 00:53:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qinmin@chromium.org/149273005/1
6 years, 10 months ago (2014-02-18 00:53:49 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 03:51:00 UTC) #5
Message was sent while issue was closed.
Change committed as 251723

Powered by Google App Engine
This is Rietveld 408576698