Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: android_webview/native/permission/aw_permission_request.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/permission/aw_permission_request.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/permission/aw_permission_request.cc
diff --git a/android_webview/native/permission/aw_permission_request.cc b/android_webview/native/permission/aw_permission_request.cc
index f25db3e03aeff8c559d7881a7527ebaafc1166f5..27f0b5b6c59f0e7c0df0430a4da7a0980ba4fc6c 100644
--- a/android_webview/native/permission/aw_permission_request.cc
+++ b/android_webview/native/permission/aw_permission_request.cc
@@ -46,7 +46,7 @@ AwPermissionRequest::~AwPermissionRequest() {
}
void AwPermissionRequest::OnAccept(JNIEnv* env,
- jobject jcaller,
+ const JavaParamRef<jobject>& jcaller,
jboolean accept) {
OnAcceptInternal(accept);
}
@@ -66,7 +66,8 @@ void AwPermissionRequest::DeleteThis() {
j_request.obj());
}
-void AwPermissionRequest::Destroy(JNIEnv* env, jobject obj) {
+void AwPermissionRequest::Destroy(JNIEnv* env,
+ const JavaParamRef<jobject>& obj) {
delete this;
}
« no previous file with comments | « android_webview/native/permission/aw_permission_request.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698