Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: android_webview/native/aw_contents_client_bridge.h

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | android_webview/native/aw_contents_client_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_contents_client_bridge.h
diff --git a/android_webview/native/aw_contents_client_bridge.h b/android_webview/native/aw_contents_client_bridge.h
index 74f13e00403581871b27b2f736df5ebeee2c408f..5372fb07442793cd7fe35c849aca7a2b17ebc95a 100644
--- a/android_webview/native/aw_contents_client_bridge.h
+++ b/android_webview/native/aw_contents_client_bridge.h
@@ -56,12 +56,21 @@ class AwContentsClientBridge : public AwContentsClientBridgeBase {
override;
// Methods called from Java.
- void ProceedSslError(JNIEnv* env, jobject obj, jboolean proceed, jint id);
- void ProvideClientCertificateResponse(JNIEnv* env, jobject object,
- jint request_id, jobjectArray encoded_chain_ref,
- jobject private_key_ref);
- void ConfirmJsResult(JNIEnv*, jobject, int id, jstring prompt);
- void CancelJsResult(JNIEnv*, jobject, int id);
+ void ProceedSslError(JNIEnv* env,
+ const base::android::JavaRef<jobject>& obj,
+ jboolean proceed,
+ jint id);
+ void ProvideClientCertificateResponse(
+ JNIEnv* env,
+ const base::android::JavaRef<jobject>& object,
+ jint request_id,
+ const base::android::JavaRef<jobjectArray>& encoded_chain_ref,
+ const base::android::JavaRef<jobject>& private_key_ref);
+ void ConfirmJsResult(JNIEnv*,
+ const base::android::JavaRef<jobject>&,
+ int id,
+ const base::android::JavaRef<jstring>& prompt);
+ void CancelJsResult(JNIEnv*, const base::android::JavaRef<jobject>&, int id);
private:
void HandleErrorInClientCertificateResponse(int id);
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | android_webview/native/aw_contents_client_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698