android_webview/native/aw_autofill_client.h - Issue 1492703004: Pass method parameters as JavaParamRef in android_webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_autofill_client.h

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/aw_autofill_client.h

diff --git a/android_webview/native/aw_autofill_client.h b/android_webview/native/aw_autofill_client.h

index c869ddb6f58fe6b8a0a9ab4c78dcb9c0e4bb97dc..b4278ed4df69c7212a0566176e224a7e554a2436 100644

--- a/android_webview/native/aw_autofill_client.h

+++ b/android_webview/native/aw_autofill_client.h

@@ -96,7 +96,9 @@ class AwAutofillClient : public autofill::AutofillClient,

void OnFirstUserGestureObserved() override;

bool IsContextSecure(const GURL& form_origin) override;

- void SuggestionSelected(JNIEnv* env, jobject obj, jint position);

+ void SuggestionSelected(JNIEnv* env,

+ const base::android::JavaParamRef<jobject>& obj,

+ jint position);

private:

AwAutofillClient(content::WebContents* web_contents);

« no previous file with comments | « no previous file | android_webview/native/aw_autofill_client.cc » ('j') | no next file with comments »