Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Side by Side Diff: android_webview/native/aw_autofill_client.cc

Issue 1492703004: Pass method parameters as JavaParamRef in android_webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forgot to test compile unit tests before uploading, whoops Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/native/aw_autofill_client.h ('k') | android_webview/native/aw_contents.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_autofill_client.h" 5 #include "android_webview/native/aw_autofill_client.h"
6 6
7 #include "android_webview/browser/aw_browser_context.h" 7 #include "android_webview/browser/aw_browser_context.h"
8 #include "android_webview/browser/aw_content_browser_client.h" 8 #include "android_webview/browser/aw_content_browser_client.h"
9 #include "android_webview/browser/aw_form_database_service.h" 9 #include "android_webview/browser/aw_form_database_service.h"
10 #include "android_webview/browser/aw_pref_store.h" 10 #include "android_webview/browser/aw_pref_store.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 ssl_status = navigation_entry->GetSSL(); 187 ssl_status = navigation_entry->GetSSL();
188 // Note: The implementation below is a copy of the one in 188 // Note: The implementation below is a copy of the one in
189 // ChromeAutofillClient::IsContextSecure, and should be kept in sync 189 // ChromeAutofillClient::IsContextSecure, and should be kept in sync
190 // until crbug.com/505388 gets implemented. 190 // until crbug.com/505388 gets implemented.
191 return ssl_status.security_style == 191 return ssl_status.security_style ==
192 content::SECURITY_STYLE_AUTHENTICATED && 192 content::SECURITY_STYLE_AUTHENTICATED &&
193 ssl_status.content_status == content::SSLStatus::NORMAL_CONTENT; 193 ssl_status.content_status == content::SSLStatus::NORMAL_CONTENT;
194 } 194 }
195 195
196 void AwAutofillClient::SuggestionSelected(JNIEnv* env, 196 void AwAutofillClient::SuggestionSelected(JNIEnv* env,
197 jobject object, 197 const JavaParamRef<jobject>& object,
198 jint position) { 198 jint position) {
199 if (delegate_) { 199 if (delegate_) {
200 delegate_->DidAcceptSuggestion(suggestions_[position].value, 200 delegate_->DidAcceptSuggestion(suggestions_[position].value,
201 suggestions_[position].frontend_id, 201 suggestions_[position].frontend_id,
202 position); 202 position);
203 } 203 }
204 } 204 }
205 205
206 void AwAutofillClient::HideRequestAutocompleteDialog() { 206 void AwAutofillClient::HideRequestAutocompleteDialog() {
207 NOTIMPLEMENTED(); 207 NOTIMPLEMENTED();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 content::RenderFrameHost* rfh, 250 content::RenderFrameHost* rfh,
251 const ResultCallback& callback) { 251 const ResultCallback& callback) {
252 NOTIMPLEMENTED(); 252 NOTIMPLEMENTED();
253 } 253 }
254 254
255 bool RegisterAwAutofillClient(JNIEnv* env) { 255 bool RegisterAwAutofillClient(JNIEnv* env) {
256 return RegisterNativesImpl(env); 256 return RegisterNativesImpl(env);
257 } 257 }
258 258
259 } // namespace android_webview 259 } // namespace android_webview
OLDNEW
« no previous file with comments | « android_webview/native/aw_autofill_client.h ('k') | android_webview/native/aw_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698