Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1492663006: Improved handling of importer profile creation. (Closed)

Created:
5 years ago by forshaw
Modified:
5 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improved handling of importer profile creation. This patch improves the handling of importer profile creation to remove reliance on bare pointers. It also wraps created importer objects in a scoped_refptr which is what the pointer is assigned to in the caller. BUG=539746 Committed: https://crrev.com/d07bcf1b1fb4172a9a00fcc7bbddb685c0a33f8e Cr-Commit-Position: refs/heads/master@{#363033}

Patch Set 1 #

Patch Set 2 : Added missing header file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -54 lines) Patch
M chrome/browser/importer/importer_list.h View 1 2 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/importer/importer_list.cc View 6 chunks +39 lines, -42 lines 0 comments Download
M chrome/utility/importer/importer_creator.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/utility/importer/importer_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
forshaw
isherman@ this is the CL for fixing up the memory handling of importers you requested. ...
5 years ago (2015-12-03 18:31:12 UTC) #2
Ilya Sherman
LGTM. Thanks very much for the cleanup +)
5 years ago (2015-12-03 18:34:47 UTC) #3
Ilya Sherman
On 2015/12/03 18:34:47, Ilya Sherman wrote: > LGTM. Thanks very much for the cleanup +) ...
5 years ago (2015-12-03 18:35:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1492663006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1492663006/20001
5 years ago (2015-12-03 18:35:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 19:30:48 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 19:31:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d07bcf1b1fb4172a9a00fcc7bbddb685c0a33f8e
Cr-Commit-Position: refs/heads/master@{#363033}

Powered by Google App Engine
This is Rietveld 408576698