Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: test/cctest/test-api.cc

Issue 1492653004: [cleanup] Introduce PropertyFilter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: windows ♥ Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-alloc.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index eb5df5ebe04414eeda393ab18dd7325d1ecd4da6..af512296fb0c5a7aab1d65811a1c7dc8e21d45a9 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -10733,8 +10733,8 @@ THREADED_TEST(Regress91517) {
// Call the runtime version of GetOwnPropertyNames() on the natively
// created object through JavaScript.
CHECK(context->Global()->Set(context.local(), v8_str("obj"), o4).FromJust());
- // PROPERTY_ATTRIBUTES_NONE = 0
- CompileRun("var names = %GetOwnPropertyNames(obj, 0);");
+ // PROPERTY_ATTRIBUTES_PRIVATE_SYMBOL = 32
+ CompileRun("var names = %GetOwnPropertyNames(obj, 32);");
ExpectInt32("names.length", 1006);
ExpectTrue("names.indexOf(\"baz\") >= 0");
@@ -10797,8 +10797,8 @@ THREADED_TEST(Regress269562) {
// the natively created object through JavaScript.
CHECK(context->Global()->Set(context.local(), v8_str("obj"), o2).FromJust());
CHECK(context->Global()->Set(context.local(), v8_str("sym"), sym).FromJust());
- // PROPERTY_ATTRIBUTES_NONE = 0
- CompileRun("var names = %GetOwnPropertyNames(obj, 0);");
+ // PROPERTY_ATTRIBUTES_PRIVATE_SYMBOL = 32
+ CompileRun("var names = %GetOwnPropertyNames(obj, 32);");
ExpectInt32("names.length", 7);
ExpectTrue("names.indexOf(\"foo\") >= 0");
« no previous file with comments | « test/cctest/test-alloc.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698