Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: src/runtime/runtime-array.cc

Issue 1492653004: [cleanup] Introduce PropertyFilter (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: windows ♥ Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/property-details.h ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/conversions-inl.h" 8 #include "src/conversions-inl.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/factory.h" 10 #include "src/factory.h"
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 CONVERT_ARG_HANDLE_CHECKED(JSObject, array, 0); 199 CONVERT_ARG_HANDLE_CHECKED(JSObject, array, 0);
200 CONVERT_NUMBER_CHECKED(uint32_t, length, Uint32, args[1]); 200 CONVERT_NUMBER_CHECKED(uint32_t, length, Uint32, args[1]);
201 201
202 if (!array->elements()->IsDictionary()) { 202 if (!array->elements()->IsDictionary()) {
203 RUNTIME_ASSERT(array->HasFastSmiOrObjectElements() || 203 RUNTIME_ASSERT(array->HasFastSmiOrObjectElements() ||
204 array->HasFastDoubleElements()); 204 array->HasFastDoubleElements());
205 uint32_t actual_length = static_cast<uint32_t>(array->elements()->length()); 205 uint32_t actual_length = static_cast<uint32_t>(array->elements()->length());
206 return *isolate->factory()->NewNumberFromUint(Min(actual_length, length)); 206 return *isolate->factory()->NewNumberFromUint(Min(actual_length, length));
207 } 207 }
208 208
209 KeyAccumulator accumulator(isolate); 209 KeyAccumulator accumulator(isolate, ALL_PROPERTIES);
210 // No need to separate protoype levels since we only get numbers/element keys 210 // No need to separate protoype levels since we only get numbers/element keys
211 for (PrototypeIterator iter(isolate, array, 211 for (PrototypeIterator iter(isolate, array,
212 PrototypeIterator::START_AT_RECEIVER); 212 PrototypeIterator::START_AT_RECEIVER);
213 !iter.IsAtEnd(); iter.Advance()) { 213 !iter.IsAtEnd(); iter.Advance()) {
214 if (PrototypeIterator::GetCurrent(iter)->IsJSProxy() || 214 if (PrototypeIterator::GetCurrent(iter)->IsJSProxy() ||
215 PrototypeIterator::GetCurrent<JSObject>(iter) 215 PrototypeIterator::GetCurrent<JSObject>(iter)
216 ->HasIndexedInterceptor()) { 216 ->HasIndexedInterceptor()) {
217 // Bail out if we find a proxy or interceptor, likely not worth 217 // Bail out if we find a proxy or interceptor, likely not worth
218 // collecting keys in that case. 218 // collecting keys in that case.
219 return *isolate->factory()->NewNumberFromUint(length); 219 return *isolate->factory()->NewNumberFromUint(length);
220 } 220 }
221 accumulator.NextPrototype(); 221 accumulator.NextPrototype();
222 Handle<JSObject> current = PrototypeIterator::GetCurrent<JSObject>(iter); 222 Handle<JSObject> current = PrototypeIterator::GetCurrent<JSObject>(iter);
223 JSObject::CollectOwnElementKeys(current, &accumulator, NONE); 223 JSObject::CollectOwnElementKeys(current, &accumulator, ALL_PROPERTIES);
224 } 224 }
225 // Erase any keys >= length. 225 // Erase any keys >= length.
226 // TODO(adamk): Remove this step when the contract of %GetArrayKeys 226 // TODO(adamk): Remove this step when the contract of %GetArrayKeys
227 // is changed to let this happen on the JS side. 227 // is changed to let this happen on the JS side.
228 Handle<FixedArray> keys = accumulator.GetKeys(KEEP_NUMBERS); 228 Handle<FixedArray> keys = accumulator.GetKeys(KEEP_NUMBERS);
229 for (int i = 0; i < keys->length(); i++) { 229 for (int i = 0; i < keys->length(); i++) {
230 if (NumberToUint32(keys->get(i)) >= length) keys->set_undefined(i); 230 if (NumberToUint32(keys->get(i)) >= length) keys->set_undefined(i);
231 } 231 }
232 return *isolate->factory()->NewJSArrayWithElements(keys); 232 return *isolate->factory()->NewJSArrayWithElements(keys);
233 } 233 }
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 482
483 RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) { 483 RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) {
484 SealHandleScope shs(isolate); 484 SealHandleScope shs(isolate);
485 DCHECK(args.length() == 2); 485 DCHECK(args.length() == 2);
486 // Returning undefined means that this fast path fails and one has to resort 486 // Returning undefined means that this fast path fails and one has to resort
487 // to a slow path. 487 // to a slow path.
488 return isolate->heap()->undefined_value(); 488 return isolate->heap()->undefined_value();
489 } 489 }
490 } // namespace internal 490 } // namespace internal
491 } // namespace v8 491 } // namespace v8
OLDNEW
« no previous file with comments | « src/property-details.h ('k') | src/runtime/runtime-object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698